From 304554115a2f2dc316386a9ea5bec237d67f595f Mon Sep 17 00:00:00 2001 From: Steven Danneman Date: Wed, 3 Sep 2008 15:31:39 -0700 Subject: Cleanup of DC enumeration in get_dcs() This is a fix for a few small inefficiencies/bugs in the get_dcs() path. * because the third add_one_dc_unique() loop was outside the ADS check all DCs returned from the non-sitename lookup were being tacked onto the dc_name_ip list twice. * add_one_dc_unique() now checks if the given IP address already exists before adding it to the list, making the returned list actually unique * added more thorough doxygen comment headers (This used to be commit cb2d488e1dbd90953c496c5e25d648977884f7e3) --- source3/libsmb/conncache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source3/libsmb') diff --git a/source3/libsmb/conncache.c b/source3/libsmb/conncache.c index 05344f4071..b440d61048 100644 --- a/source3/libsmb/conncache.c +++ b/source3/libsmb/conncache.c @@ -177,7 +177,7 @@ void delete_negative_conn_cache(const char *domain, const char *server) /** - * Add an entry to the failed conneciton cache + * Add an entry to the failed connection cache * * @param[in] domain * @param[in] server may be a FQDN or an IP addr in printable form -- cgit