From 5363d6e62c2d4d3275e78d04c48835524c54f620 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Thu, 12 Nov 2009 13:56:33 -0800 Subject: Ensure all callers to the rpc_client/cli_pipe functions correctly initialize return variables. Jeremy. --- source3/libsmb/libsmb_dir.c | 2 +- source3/libsmb/libsmb_server.c | 4 ++-- source3/libsmb/passchange.c | 4 ++-- source3/libsmb/trusts_util.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) (limited to 'source3/libsmb') diff --git a/source3/libsmb/libsmb_dir.c b/source3/libsmb/libsmb_dir.c index 6a4613c3c3..73bbf82861 100644 --- a/source3/libsmb/libsmb_dir.c +++ b/source3/libsmb/libsmb_dir.c @@ -267,7 +267,7 @@ net_share_enum_rpc(struct cli_state *cli, struct srvsvc_NetShareCtr1 ctr1; fstring name = ""; fstring comment = ""; - struct rpc_pipe_client *pipe_hnd; + struct rpc_pipe_client *pipe_hnd = NULL; NTSTATUS nt_status; uint32_t resume_handle = 0; uint32_t total_entries = 0; diff --git a/source3/libsmb/libsmb_server.c b/source3/libsmb/libsmb_server.c index db9d6de40f..a572acde96 100644 --- a/source3/libsmb/libsmb_server.c +++ b/source3/libsmb/libsmb_server.c @@ -713,8 +713,8 @@ SMBC_attr_server(TALLOC_CTX *ctx, { int flags; struct sockaddr_storage ss; - struct cli_state *ipc_cli; - struct rpc_pipe_client *pipe_hnd; + struct cli_state *ipc_cli = NULL; + struct rpc_pipe_client *pipe_hnd = NULL; NTSTATUS nt_status; SMBCSRV *srv=NULL; SMBCSRV *ipc_srv=NULL; diff --git a/source3/libsmb/passchange.c b/source3/libsmb/passchange.c index 570a048502..e8c412be46 100644 --- a/source3/libsmb/passchange.c +++ b/source3/libsmb/passchange.c @@ -28,8 +28,8 @@ NTSTATUS remote_password_change(const char *remote_machine, const char *user_nam char **err_str) { struct nmb_name calling, called; - struct cli_state *cli; - struct rpc_pipe_client *pipe_hnd; + struct cli_state *cli = NULL; + struct rpc_pipe_client *pipe_hnd = NULL; struct sockaddr_storage ss; char *user, *domain, *p; diff --git a/source3/libsmb/trusts_util.c b/source3/libsmb/trusts_util.c index 5dda3c52dd..e127c9a67b 100644 --- a/source3/libsmb/trusts_util.c +++ b/source3/libsmb/trusts_util.c @@ -142,7 +142,7 @@ bool enumerate_domain_trusts( TALLOC_CTX *mem_ctx, const char *domain, struct sockaddr_storage dc_ss; uint32 enum_ctx = 0; struct cli_state *cli = NULL; - struct rpc_pipe_client *lsa_pipe; + struct rpc_pipe_client *lsa_pipe = NULL; bool retry; struct lsa_DomainList dom_list; int i; -- cgit