From bfe4a2baeec6bc4558a617ec67532ea11f865861 Mon Sep 17 00:00:00 2001 From: Richard Sharpe Date: Tue, 15 May 2012 07:47:14 -0700 Subject: Fix the overwriting of errno before use in a DEBUG statement and use the return value from store_acl_blob_fsp rather than ignoring it. Autobuild-User: Richard Sharpe Autobuild-Date: Wed May 16 03:43:41 CEST 2012 on sn-devel-104 --- source3/modules/vfs_acl_common.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'source3/modules/vfs_acl_common.c') diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c index 241bc8f7e6..221b43f748 100644 --- a/source3/modules/vfs_acl_common.c +++ b/source3/modules/vfs_acl_common.c @@ -592,10 +592,13 @@ static NTSTATUS fset_nt_acl_common(vfs_handle_struct *handle, files_struct *fsp, NDR_PRINT_DEBUG(security_descriptor, discard_const_p(struct security_descriptor, psd)); } + /* + * Perhaps create_acl_blob should have a status return as well + */ create_acl_blob(psd, &blob, XATTR_SD_HASH_TYPE_SHA256, hash); - store_acl_blob_fsp(handle, fsp, &blob); + status = store_acl_blob_fsp(handle, fsp, &blob); - return NT_STATUS_OK; + return status; } static int acl_common_remove_object(vfs_handle_struct *handle, -- cgit