From 6c49f90965327a7f70d24fecdb7529f3f78fc9e4 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Fri, 21 Jun 2013 09:56:22 -0700 Subject: Fix glusterfs backend crash found at the Microsoft interop event. Based on a fix originally from Raghavendra Talur . When a new document is created in explorer, a check for file_exist is made. vfs_gluster_get_real_filename was returning 0 even when the file did not exist. Signed-off-by: Jeremy Allison Reviewed-by: "Christopher R. Hertel" --- source3/modules/vfs_glusterfs.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'source3/modules') diff --git a/source3/modules/vfs_glusterfs.c b/source3/modules/vfs_glusterfs.c index 24e1bdaea7..1323e0e17f 100644 --- a/source3/modules/vfs_glusterfs.c +++ b/source3/modules/vfs_glusterfs.c @@ -894,8 +894,10 @@ static int vfs_gluster_get_real_filename(struct vfs_handle_struct *handle, "user.glusterfs.get_real_filename:%s", name); ret = glfs_getxattr(handle->data, path, key_buf, val_buf, NAME_MAX + 1); - if (ret == -1 && errno == ENODATA) { - errno = EOPNOTSUPP; + if (ret == -1) { + if (errno == ENODATA) { + errno = EOPNOTSUPP; + } return -1; } -- cgit