From 8b9c5f04831216aa3d3b89fd2a81be12ac8592dd Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Mon, 18 May 2009 09:36:16 +0200 Subject: Fix a race condition in vfs_aio_fork with gpfs share modes --- source3/modules/vfs_aio_fork.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'source3/modules') diff --git a/source3/modules/vfs_aio_fork.c b/source3/modules/vfs_aio_fork.c index 8568ec3916..e706495a56 100644 --- a/source3/modules/vfs_aio_fork.c +++ b/source3/modules/vfs_aio_fork.c @@ -357,6 +357,14 @@ static void aio_child_loop(int sockfd, struct mmap_area *map) ret_struct.ret_errno = errno; } + /* + * Close the fd before telling our parent we're done. The + * parent might close and re-open the file very quickly, and + * with system-level share modes (GPFS) we would get an + * unjustified SHARING_VIOLATION. + */ + close(fd); + ret = write_data(sockfd, (char *)&ret_struct, sizeof(ret_struct)); if (ret != sizeof(ret_struct)) { @@ -364,8 +372,6 @@ static void aio_child_loop(int sockfd, struct mmap_area *map) strerror(errno))); exit(2); } - - close(fd); } } -- cgit