From c52b3fb89f29110d2c2026a540e5dd39826bb799 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Mon, 28 Aug 2006 09:19:30 +0000 Subject: r17881: Another microstep towards better error reporting: Make get_sorted_dc_list return NTSTATUS. If we want to differentiate different name resolution problems we might want to introduce yet another error class for Samba-internal errors. Things like no route to host to the WINS server, a DNS server explicitly said host not found etc might be worth passing up. Because we can not stash everything into the existing NT_STATUS codes, what about a Samba-specific error class like NT_STATUS_DOS and NT_STATUS_LDAP? Volker (This used to be commit 60a166f0347170dff38554bed46193ce1226c8c1) --- source3/nsswitch/winbindd_rpc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'source3/nsswitch') diff --git a/source3/nsswitch/winbindd_rpc.c b/source3/nsswitch/winbindd_rpc.c index d8797ee2bc..f4676cc2fe 100644 --- a/source3/nsswitch/winbindd_rpc.c +++ b/source3/nsswitch/winbindd_rpc.c @@ -774,7 +774,8 @@ static int get_ldap_sequence_number( const char* domain, uint32 *seq) struct ip_service *ip_list = NULL; int count; - if ( !get_sorted_dc_list(domain, &ip_list, &count, False) ) { + if ( !NT_STATUS_IS_OK(get_sorted_dc_list(domain, &ip_list, &count, + False)) ) { DEBUG(3, ("Could not look up dc's for domain %s\n", domain)); return False; } -- cgit