From 2568a8b4635bb7fb76dbd4bdd5eb2decb09f708a Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox@samba.org>
Date: Wed, 20 Jul 2011 16:48:07 +0200
Subject: s3:loadparm: untangle assignment from check in do_section()

---
 source3/param/loadparm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'source3/param')

diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index 3b4ff6a799..875aa6ed75 100644
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -7674,8 +7674,8 @@ static bool do_section(const char *pszSectionName, void *userdata)
 		/* issued by the post-processing of a previous section. */
 		DEBUG(2, ("Processing section \"[%s]\"\n", pszSectionName));
 
-		if ((iServiceIndex = add_a_service(&sDefault, pszSectionName))
-		    < 0) {
+		iServiceIndex = add_a_service(&sDefault, pszSectionName);
+		if (iServiceIndex < 0) {
 			DEBUG(0, ("Failed to add a new service\n"));
 			return (false);
 		}
-- 
cgit