From ac5600fc7e996bdde23666bc96a834044556c85f Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Mon, 28 Jun 2010 11:06:22 +0200 Subject: s3-passdb: Make sure dn is initialized and don't free it. dn is just a pointer to a memory which hasn't been duplicated. Found by clang-analyzer. --- source3/passdb/pdb_ads.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'source3/passdb/pdb_ads.c') diff --git a/source3/passdb/pdb_ads.c b/source3/passdb/pdb_ads.c index c5d8cc2c02..096063b0a0 100644 --- a/source3/passdb/pdb_ads.c +++ b/source3/passdb/pdb_ads.c @@ -1190,7 +1190,7 @@ static NTSTATUS pdb_ads_delete_alias(struct pdb_methods *m, m->private_data, struct pdb_ads_state); struct tldap_context *ld; struct tldap_message **alias; - char *sidstr, *dn; + char *sidstr, *dn = NULL; int rc; ld = pdb_ads_ld(state); @@ -1213,7 +1213,6 @@ static NTSTATUS pdb_ads_delete_alias(struct pdb_methods *m, if (rc != TLDAP_SUCCESS) { DEBUG(10, ("ldap_search failed: %s\n", tldap_errstr(talloc_tos(), state->ld, rc))); - TALLOC_FREE(dn); return NT_STATUS_LDAP(rc); } if (talloc_array_length(alias) != 1) { @@ -1231,7 +1230,6 @@ static NTSTATUS pdb_ads_delete_alias(struct pdb_methods *m, if (rc != TLDAP_SUCCESS) { DEBUG(10, ("ldap_delete failed: %s\n", tldap_errstr(talloc_tos(), state->ld, rc))); - TALLOC_FREE(dn); return NT_STATUS_LDAP(rc); } -- cgit