From b78dd91e68d6273d1fcd3470b1c3c333047fb186 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 1 Jul 2003 12:40:52 +0000 Subject: Fix two memory leaks. tdb_search_keys allocates space for the key strings. Running 'net cache list' or secrets_get_trusted_domains through valgrind gives a *huge* amount of invalid reads of one byte beyond the indicated string length in libc's strncpy. Annoying... Volker (This used to be commit 0f8933ae778064ff58cdc832ce52c843631435bb) --- source3/passdb/secrets.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'source3/passdb/secrets.c') diff --git a/source3/passdb/secrets.c b/source3/passdb/secrets.c index f91d59989f..57a539b092 100644 --- a/source3/passdb/secrets.c +++ b/source3/passdb/secrets.c @@ -615,6 +615,8 @@ NTSTATUS secrets_get_trusted_domains(TALLOC_CTX* ctx, int* enum_ctx, unsigned in DEBUG(0, ("strndup failed!\n")); return NT_STATUS_NO_MEMORY; } + + SAFE_FREE(k->node_key.dptr); packed_pass = secrets_fetch(secrets_key, &size); packed_size = tdb_trusted_dom_pass_unpack(packed_pass, size, pass); -- cgit