From 989ad44d32c2e77972a966d91f1813b0b929f83b Mon Sep 17 00:00:00 2001 From: todd stecher Date: Mon, 19 Jan 2009 15:09:51 -0800 Subject: Memory leaks and other fixes found by Coverity --- source3/passdb/pdb_interface.c | 6 ++++++ source3/passdb/pdb_ldap.c | 1 + 2 files changed, 7 insertions(+) (limited to 'source3/passdb') diff --git a/source3/passdb/pdb_interface.c b/source3/passdb/pdb_interface.c index b13644bac3..486b5b1b80 100644 --- a/source3/passdb/pdb_interface.c +++ b/source3/passdb/pdb_interface.c @@ -605,6 +605,9 @@ static NTSTATUS pdb_default_delete_dom_group(struct pdb_methods *methods, struct group *grp; const char *grp_name; + /* coverity */ + map.gid = (gid_t) -1; + sid_compose(&group_sid, get_global_sam_sid(), rid); if (!get_domain_group_from_sid(group_sid, &map)) { @@ -780,6 +783,9 @@ static NTSTATUS pdb_default_add_groupmem(struct pdb_methods *methods, const char *group_name; uid_t uid; + /* coverity */ + map.gid = (gid_t) -1; + sid_compose(&group_sid, get_global_sam_sid(), group_rid); sid_compose(&member_sid, get_global_sam_sid(), member_rid); diff --git a/source3/passdb/pdb_ldap.c b/source3/passdb/pdb_ldap.c index f031483ea1..043b620756 100644 --- a/source3/passdb/pdb_ldap.c +++ b/source3/passdb/pdb_ldap.c @@ -4221,6 +4221,7 @@ const char **talloc_attrs(TALLOC_CTX *mem_ctx, ...) result[i] = talloc_strdup(result, va_arg(ap, const char*)); if (result[i] == NULL) { talloc_free(result); + va_end(ap); return NULL; } } -- cgit