From c186f92437a918a256b84be84dcf6de569f0cc20 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sun, 11 Jul 2010 17:30:53 +0200 Subject: s3: [ug]id_to_unix_... can not fail Remove some silly failure checks --- source3/passdb/util_unixsids.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) (limited to 'source3/passdb') diff --git a/source3/passdb/util_unixsids.c b/source3/passdb/util_unixsids.c index 08c887e9fa..0894804c5b 100644 --- a/source3/passdb/util_unixsids.c +++ b/source3/passdb/util_unixsids.c @@ -35,14 +35,22 @@ bool sid_check_is_in_unix_users(const struct dom_sid *sid) return sid_check_is_unix_users(&dom_sid); } -bool uid_to_unix_users_sid(uid_t uid, struct dom_sid *sid) +void uid_to_unix_users_sid(uid_t uid, struct dom_sid *sid) { - return sid_compose(sid, &global_sid_Unix_Users, uid); + /* + * This can never fail, we know that global_sid_Unix_Users is + * short enough for a domain sid. + */ + sid_compose(sid, &global_sid_Unix_Users, uid); } -bool gid_to_unix_groups_sid(gid_t gid, struct dom_sid *sid) +void gid_to_unix_groups_sid(gid_t gid, struct dom_sid *sid) { - return sid_compose(sid, &global_sid_Unix_Groups, gid); + /* + * This can never fail, we know that global_sid_Unix_Groups is + * short enough for a domain sid. + */ + sid_compose(sid, &global_sid_Unix_Groups, gid); } const char *unix_users_domain_name(void) -- cgit