From e00ac55994ad7d067f7f628ae4157f0d23f819c4 Mon Sep 17 00:00:00 2001 From: Michele Baldessari Date: Wed, 5 Sep 2012 10:56:06 -0700 Subject: Free protect_ids in secret_store_domain_sid() as the caller of fetch_secrets() must free the result in order to not leak memory. Signed-off-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed Sep 5 22:20:45 CEST 2012 on sn-devel-104 --- source3/passdb/machine_account_secrets.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'source3/passdb') diff --git a/source3/passdb/machine_account_secrets.c b/source3/passdb/machine_account_secrets.c index 300455a2e5..70d7106176 100644 --- a/source3/passdb/machine_account_secrets.c +++ b/source3/passdb/machine_account_secrets.c @@ -101,9 +101,11 @@ bool secrets_store_domain_sid(const char *domain, const struct dom_sid *sid) if (strncmp(protect_ids, "TRUE", 4)) { DEBUG(0, ("Refusing to store a Domain SID, " "it has been marked as protected!\n")); + SAFE_FREE(protect_ids); return false; } } + SAFE_FREE(protect_ids); #endif ret = secrets_store(domain_sid_keystr(domain), sid, sizeof(struct dom_sid )); -- cgit