From ed5fbd743be07a3c6e1a3879df283d0222ef0eb5 Mon Sep 17 00:00:00 2001
From: Jean-François Micouleau <jfm@samba.org>
Date: Mon, 27 Sep 1999 13:12:55 +0000
Subject: don't leak printer handles, don't coredump when adding forms, and a
 small non obvious memory leak in the rpc buffers

	J.F.
(This used to be commit bee11f8889378b9f1cc6e2818fd0f8dd7ddcf10d)
---
 source3/printing/nt_printing.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'source3/printing')

diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index a384b8e31a..90a53f1f7c 100644
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -126,7 +126,7 @@ int write_ntforms(nt_forms_struct **list, int number)
 /****************************************************************************
 add a form struct at the end of the list
 ****************************************************************************/
-void add_a_form(nt_forms_struct **list, FORM form, int count)
+void add_a_form(nt_forms_struct **list, FORM form, int *count)
 {
 	int n=0;
 	BOOL update;
@@ -141,7 +141,7 @@ void add_a_form(nt_forms_struct **list, FORM form, int count)
 	update=False;
 	
 	unistr2_to_ascii(form_name, &(form.name), sizeof(form_name)-1);
-	for (n=0; n<count && update==False; n++)
+	for (n=0; n<*count && update==False; n++)
 	{
 		if (!strncmp((*list)[n].name, form_name, strlen(form_name)))
 		{
@@ -154,6 +154,7 @@ void add_a_form(nt_forms_struct **list, FORM form, int count)
 	{
 		*list=Realloc(*list, (n+1)*sizeof(nt_forms_struct));
 		unistr2_to_ascii((*list)[n].name, &(form.name), sizeof((*list)[n].name)-1);
+		(*count)++;
 	}
 	
 	(*list)[n].flag=form.flags;
@@ -163,7 +164,6 @@ void add_a_form(nt_forms_struct **list, FORM form, int count)
 	(*list)[n].top=form.top;
 	(*list)[n].right=form.right;
 	(*list)[n].bottom=form.bottom;
-
 }
 
 /****************************************************************************
-- 
cgit