From 185d858dd2161a42cc35d318415844561531f4a4 Mon Sep 17 00:00:00 2001 From: Martin Pool Date: Tue, 18 Feb 2003 07:15:52 +0000 Subject: Check return code of string_to_sid. (Merge from HEAD) (This used to be commit 606bb47f241d2916d039b38f48b50474a3e0dadc) --- source3/python/py_lsa.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'source3/python/py_lsa.c') diff --git a/source3/python/py_lsa.c b/source3/python/py_lsa.c index 31706af684..22db29665a 100644 --- a/source3/python/py_lsa.c +++ b/source3/python/py_lsa.c @@ -235,7 +235,10 @@ static PyObject *lsa_lookup_sids(PyObject *self, PyObject *args, for (i = 0; i < num_sids; i++) { PyObject *obj = PyList_GetItem(py_sids, i); - string_to_sid(&sids[i], PyString_AsString(obj)); + if (!string_to_sid(&sids[i], PyString_AsString(obj))) { + PyErr_SetString(PyExc_ValueError, "string_to_sid failed"); + return NULL; + } } } else { @@ -245,7 +248,10 @@ static PyObject *lsa_lookup_sids(PyObject *self, PyObject *args, num_sids = 1; sids = (DOM_SID *)talloc(hnd->mem_ctx, sizeof(DOM_SID)); - string_to_sid(&sids[0], PyString_AsString(py_sids)); + if (!string_to_sid(&sids[0], PyString_AsString(py_sids))) { + PyErr_SetString(PyExc_ValueError, "string_to_sid failed"); + return NULL; + } } ntstatus = cli_lsa_lookup_sids(hnd->cli, hnd->mem_ctx, &hnd->pol, -- cgit