From 5f8fc63515a02aaf55719cb8d3be8ce695178fe9 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Thu, 25 Mar 2010 14:10:25 +0100 Subject: s3:rpc_transport_np: add comment about bad usage in a destructor metze --- source3/rpc_client/rpc_transport_np.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'source3/rpc_client/rpc_transport_np.c') diff --git a/source3/rpc_client/rpc_transport_np.c b/source3/rpc_client/rpc_transport_np.c index 5b6a2d6ae0..96a8988e64 100644 --- a/source3/rpc_client/rpc_transport_np.c +++ b/source3/rpc_client/rpc_transport_np.c @@ -34,7 +34,8 @@ static int rpc_transport_np_state_destructor(struct rpc_transport_np_state *s) DEBUG(10, ("socket was closed, no need to send close request.\n")); return 0; } - + + /* TODO: do not use a sync call with a destructor!!! */ if (!NT_STATUS_IS_OK(cli_close(s->cli, s->fnum))) { DEBUG(1, ("rpc_transport_np_state_destructor: cli_close " "failed on pipe %s. Error was %s\n", s->pipe_name, -- cgit