From 0f256c31c0cc906218d06eb9bdda4e937fd5587e Mon Sep 17 00:00:00 2001
From: Jeremy Allison <jra@samba.org>
Date: Mon, 19 Jun 2006 23:21:47 +0000
Subject: r16377: Klocwork #1077. Jeremy. (This used to be commit
 72709a8465caf5b7d95911250234f203b0ff4675)

---
 source3/rpc_parse/parse_spoolss.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

(limited to 'source3/rpc_parse')

diff --git a/source3/rpc_parse/parse_spoolss.c b/source3/rpc_parse/parse_spoolss.c
index ec2d6b8430..692a8c6ddf 100644
--- a/source3/rpc_parse/parse_spoolss.c
+++ b/source3/rpc_parse/parse_spoolss.c
@@ -5005,11 +5005,16 @@ static BOOL uniarray_2_dosarray(BUFFER5 *buf5, fstring **ar)
 		rpcstr_pull(f, src, sizeof(f)-1, -1, STR_TERMINATE);
 		src = skip_unibuf(src, 2*buf5->buf_len - PTR_DIFF(src,buf5->buffer));
 		*ar = SMB_REALLOC_ARRAY(*ar, fstring, n+2);
-		if (!*ar)
+		if (!*ar) {
 			return False;
+		}
 		fstrcpy((*ar)[n], f);
 		n++;
 	}
+	if (!*ar) {
+		return False;
+	}
+
 	fstrcpy((*ar)[n], "");
  
 	return True;
-- 
cgit