From bcf59e2575a486629a52f9d2e7cb29260595686f Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Wed, 4 Jun 2003 06:22:44 +0000 Subject: Fix for previous checkin. Only use talloc on unmarshalling or we'll leak memory. Jeremy. (This used to be commit 07a76eb2e01833d5e2e447391cffeda712118c20) --- source3/rpc_parse/parse_samr.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'source3/rpc_parse') diff --git a/source3/rpc_parse/parse_samr.c b/source3/rpc_parse/parse_samr.c index 643b35e2e7..2146ccec91 100644 --- a/source3/rpc_parse/parse_samr.c +++ b/source3/rpc_parse/parse_samr.c @@ -4619,9 +4619,11 @@ BOOL samr_io_r_query_aliasmem(const char *desc, SAMR_R_QUERY_ALIASMEM * r_u, if(!prs_uint32("num_sids1", ps, depth, &r_u->num_sids1)) return False; - ptr_sid = talloc(ps->mem_ctx, sizeof(uint32) * r_u->num_sids1); - if (!ptr_sid) { - return False; + if (UNMARSHALLING(ps)) { + ptr_sid = talloc(ps->mem_ctx, sizeof(uint32) * r_u->num_sids1); + if (!ptr_sid) { + return False; + } } for (i = 0; i < r_u->num_sids1; i++) { -- cgit