From fb82ab78fe556656eec605d532e0dabb2f815573 Mon Sep 17 00:00:00 2001
From: Jeremy Allison <jra@samba.org>
Date: Fri, 15 Dec 2000 23:02:01 +0000
Subject: Never free anything in the rpc_parse/prs_XXX functions. Do it in the
 enclosing function. lib/util_unistr.c: Check lengths *before* reading source
 - prevent uninitialised memory reads. Jeremy. (This used to be commit
 ce4f461965c872fbfc9fe5f6b98aed58bb3dd67a)

---
 source3/rpc_parse/parse_lsa.c | 10 ----------
 1 file changed, 10 deletions(-)

(limited to 'source3/rpc_parse')

diff --git a/source3/rpc_parse/parse_lsa.c b/source3/rpc_parse/parse_lsa.c
index 41219854d1..2c15166f26 100644
--- a/source3/rpc_parse/parse_lsa.c
+++ b/source3/rpc_parse/parse_lsa.c
@@ -853,16 +853,6 @@ static BOOL lsa_io_trans_names(char *desc, LSA_TRANS_NAME_ENUM *trn,
 			if(!prs_align(ps))
 				return False;
 		}
-
-		/* Free memory if we've sent it */
-
-		if (MARSHALLING(ps)) {
-			safe_free(trn->name);
-			safe_free(trn->uni_name);
-
-			trn->name = NULL;
-			trn->uni_name = NULL;
-		}
 	}
 
 	return True;
-- 
cgit