From 14446b528069bc27222929bb38cf72099e450018 Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Tue, 1 Mar 2011 19:17:47 +0100 Subject: s3-printing: fix move_driver_to_download_area() error paths WERR_ACCESS_DENIED errors are mapped to WERR_UNKNOWN_PRINTER_DRIVER, resulting in incorrect error messages on Windows clients. move_driver_to_download_area() returns the same error status values to the caller via the *perr argument as well as the return value. The create_directory() call is not checked for error. --- source3/rpc_server/spoolss/srv_spoolss_nt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'source3/rpc_server/spoolss') diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c index 828d06aa1e..510dde2cbd 100644 --- a/source3/rpc_server/spoolss/srv_spoolss_nt.c +++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c @@ -8003,8 +8003,8 @@ WERROR _spoolss_AddPrinterDriverEx(struct pipes_struct *p, goto done; DEBUG(5,("Moving driver to final destination\n")); - if( !W_ERROR_IS_OK(err = move_driver_to_download_area(p, r->in.info_ctr, - &err)) ) { + err = move_driver_to_download_area(p, r->in.info_ctr); + if (!W_ERROR_IS_OK(err)) { goto done; } -- cgit