From e6e80ea137c5d3c936803303c7527d2ae075de0d Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Mon, 25 Jul 2011 21:12:43 +0200 Subject: s3-spoolss: Use tmp_ctx in winreg_get_printer_dataex_internal. --- source3/rpc_server/spoolss/srv_spoolss_util.c | 31 +++++++++++++++++++-------- 1 file changed, 22 insertions(+), 9 deletions(-) (limited to 'source3/rpc_server/spoolss') diff --git a/source3/rpc_server/spoolss/srv_spoolss_util.c b/source3/rpc_server/spoolss/srv_spoolss_util.c index ea46df2fc4..1c6dcc5e30 100644 --- a/source3/rpc_server/spoolss/srv_spoolss_util.c +++ b/source3/rpc_server/spoolss/srv_spoolss_util.c @@ -327,17 +327,30 @@ WERROR winreg_get_printer_dataex_internal(TALLOC_CTX *mem_ctx, { WERROR result; struct dcerpc_binding_handle *b; + TALLOC_CTX *tmp_ctx; - result = winreg_printer_binding_handle(mem_ctx, session_info, msg_ctx, &b); - W_ERROR_NOT_OK_RETURN(result); + tmp_ctx = talloc_stackframe(); + if (tmp_ctx == NULL) { + return WERR_NOMEM; + } - return winreg_get_printer_dataex(mem_ctx, b, - printer, - key, - value, - type, - data, - data_size); + result = winreg_printer_binding_handle(tmp_ctx, session_info, msg_ctx, &b); + if (!W_ERROR_IS_OK(result)) { + talloc_free(tmp_ctx); + return result; + } + + result = winreg_get_printer_dataex(mem_ctx, + b, + printer, + key, + value, + type, + data, + data_size); + + talloc_free(tmp_ctx); + return result; } WERROR winreg_delete_printer_dataex_internal(TALLOC_CTX *mem_ctx, -- cgit