From 413ffe9adb8eea488133da0249dcb2eca08fd69d Mon Sep 17 00:00:00 2001
From: Günther Deschner <gd@samba.org>
Date: Fri, 23 Apr 2010 02:34:43 +0200
Subject: s3-spoolss: fix some crash bugs and missing error codes in AddDriver
 paths.

Found by torture test.

Guenther
---
 source3/rpc_server/srv_spoolss_nt.c | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'source3/rpc_server')

diff --git a/source3/rpc_server/srv_spoolss_nt.c b/source3/rpc_server/srv_spoolss_nt.c
index eec421f67a..72499d8ad0 100644
--- a/source3/rpc_server/srv_spoolss_nt.c
+++ b/source3/rpc_server/srv_spoolss_nt.c
@@ -7511,6 +7511,10 @@ WERROR _spoolss_AddPrinterDriverEx(pipes_struct *p,
 	 * i.e. only copy files that are newer than existing ones
 	 */
 
+	if (r->in.flags == 0) {
+		return WERR_INVALID_PARAM;
+	}
+
 	if (r->in.flags != APD_COPY_NEW_FILES) {
 		return WERR_ACCESS_DENIED;
 	}
-- 
cgit