From 59192bf03f3781fe6a21be66a7374ea72cac71f4 Mon Sep 17 00:00:00 2001
From: Günther Deschner <gd@samba.org>
Date: Fri, 15 May 2009 14:34:50 +0200
Subject: s3-samr: in _samr_QueryUserInfo() make sure to not return any info in
 error case.

Guenther
---
 source3/rpc_server/srv_samr_nt.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

(limited to 'source3/rpc_server')

diff --git a/source3/rpc_server/srv_samr_nt.c b/source3/rpc_server/srv_samr_nt.c
index 64ea1cdf3c..52864fcaa0 100644
--- a/source3/rpc_server/srv_samr_nt.c
+++ b/source3/rpc_server/srv_samr_nt.c
@@ -3024,10 +3024,15 @@ NTSTATUS _samr_QueryUserInfo(pipes_struct *p,
 		break;
 	}
 
-	TALLOC_FREE(pwd);
+	if (!NT_STATUS_IS_OK(status)) {
+		goto done;
+	}
 
 	*r->out.info = user_info;
 
+ done:
+	TALLOC_FREE(pwd);
+
 	DEBUG(5,("_samr_QueryUserInfo: %d\n", __LINE__));
 
 	return status;
-- 
cgit