From 6ff5854c4f367c9492c054d116bd94210cfc4a59 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Tue, 13 Mar 2012 21:59:32 +1100 Subject: s3-spoolss: Consistently fail OpenPrinterEx with "" printername MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit samba3.rpc.spoolss.printserver has become a flakey test recently, and this papers over the real problem. Andrew Bartlett Signed-off-by: Günther Deschner Autobuild-User: Günther Deschner Autobuild-Date: Tue Mar 13 17:51:00 CET 2012 on sn-devel-104 --- source3/rpc_server/spoolss/srv_spoolss_nt.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'source3/rpc_server') diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c index f66bea8197..daed9906fd 100644 --- a/source3/rpc_server/spoolss/srv_spoolss_nt.c +++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c @@ -1710,6 +1710,10 @@ WERROR _spoolss_OpenPrinterEx(struct pipes_struct *p, return WERR_INVALID_PARAM; } + if (!*r->in.printername) { + return WERR_INVALID_PARAM; + } + if (r->in.level > 3) { return WERR_INVALID_PARAM; } -- cgit