From 8790a2e25789bab514f8372d1b048e11fb0bae8b Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sun, 12 Mar 2006 17:44:00 +0000 Subject: r14245: We've dereferenced argv before, no point in checking. Fix Coverity bug # 144. Volker (This used to be commit d47ee82f068f1dfbae4a1c81e6bd765d5d36f09f) --- source3/rpcclient/rpcclient.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'source3/rpcclient/rpcclient.c') diff --git a/source3/rpcclient/rpcclient.c b/source3/rpcclient/rpcclient.c index 3f493ce2c5..8d70c6030a 100644 --- a/source3/rpcclient/rpcclient.c +++ b/source3/rpcclient/rpcclient.c @@ -663,13 +663,11 @@ out_free: } */ - if (argv) { - /* NOTE: popt allocates the whole argv, including the - * strings, as a single block. So a single free is - * enough to release it -- we don't free the - * individual strings. rtfm. */ - free(argv); - } + /* NOTE: popt allocates the whole argv, including the + * strings, as a single block. So a single free is + * enough to release it -- we don't free the + * individual strings. rtfm. */ + free(argv); return result; } -- cgit