From 9b0c1ab07c2c9a3fce1c49ad3d476ca1301182a4 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Fri, 21 Dec 2012 15:58:49 +0100 Subject: s3-rpcclient: Fix cmd_eventlog_loginfo() null pointer passing. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Andreas Schneider Reviewed-by: Günther Deschner Found by Coverity. --- source3/rpcclient/cmd_eventlog.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'source3/rpcclient') diff --git a/source3/rpcclient/cmd_eventlog.c b/source3/rpcclient/cmd_eventlog.c index 8acf4173b7..949e02510b 100644 --- a/source3/rpcclient/cmd_eventlog.c +++ b/source3/rpcclient/cmd_eventlog.c @@ -510,6 +510,12 @@ static NTSTATUS cmd_eventlog_loginfo(struct rpc_pipe_client *cli, return status; } + buffer = talloc_array(mem_ctx, uint8_t, bytes_needed); + if (buffer == NULL) { + status = NT_STATUS_NO_MEMORY; + goto done; + } + status = dcerpc_eventlog_GetLogInformation(b, mem_ctx, &handle, 0, /* level */ @@ -526,8 +532,8 @@ static NTSTATUS cmd_eventlog_loginfo(struct rpc_pipe_client *cli, } buf_size = bytes_needed; - buffer = talloc_array(mem_ctx, uint8_t, bytes_needed); - if (!buffer) { + buffer = talloc_realloc(mem_ctx, buffer, uint8_t, bytes_needed); + if (buffer == NULL) { status = NT_STATUS_NO_MEMORY; goto done; } -- cgit