From 200bd10b32107b4ce8fc72cc2abbf5a247708ba6 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sun, 31 Dec 2006 17:52:24 +0000 Subject: r20442: Slight rewrite of the change notify infrastructure. This now survives the first of the raw-notify subtests, the one-level test_notify_dir without any flags around yet. The tricky part was getting the data structures right, I hope the next tests don't let that fall over. fsp->notify is now by default NULL, meaning that nobody has issued a changenotify call. This means nobody is interested in changes for this directory. If that has happened, notify_change_buf collects the changes if no current request is outstanding, and it collects the requests if no change has happened since the last request. Happy New Year, somewhere on this planet it's already 2007 :-) Volker P.S: Jeremy, there's a question for you in smbd/files.c line 367. (This used to be commit ce0ad24988075465addcac0b9afc872e909135af) --- source3/smbd/close.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'source3/smbd/close.c') diff --git a/source3/smbd/close.c b/source3/smbd/close.c index a3ddcae11d..282c4acb24 100644 --- a/source3/smbd/close.c +++ b/source3/smbd/close.c @@ -416,7 +416,8 @@ static int close_directory(files_struct *fsp, enum file_close_type close_type) process_pending_change_notify_queue((time_t)0); } else { TALLOC_FREE(lck); - remove_pending_change_notify_requests_by_fid(fsp, NT_STATUS_CANCELLED); + remove_pending_change_notify_requests_by_fid( + fsp, NT_STATUS_OK); } /* -- cgit