From 940395d38bcc348eb5f1be7ba03cd554d9d3bc93 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Thu, 11 Jul 2013 16:22:26 +0200 Subject: smbd: Fix a 100% loop at shutdown time In the destructor of fsp->aio_requests[0] we put another request into fsp->aio_requests[0]. Don't overwrite that with TALLOC_FREE. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Thu Jul 11 20:56:42 CEST 2013 on sn-devel-104 --- source3/smbd/close.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'source3/smbd/close.c') diff --git a/source3/smbd/close.c b/source3/smbd/close.c index 2bd588b176..f341c72952 100644 --- a/source3/smbd/close.c +++ b/source3/smbd/close.c @@ -640,9 +640,12 @@ static NTSTATUS close_normal_file(struct smb_request *req, files_struct *fsp, while (fsp->num_aio_requests != 0) { /* * The destructor of the req will remove - * itself from the fsp + * itself from the fsp. + * Don't use TALLOC_FREE here, this will overwrite + * what the destructor just wrote into + * aio_requests[0]. */ - TALLOC_FREE(fsp->aio_requests[0]); + talloc_free(fsp->aio_requests[0]); } } -- cgit