From 34f2d189846de2cd134756d8f435370b69afb49d Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 5 Sep 2012 15:19:28 +0200 Subject: s3: Make is_stat_open() a bit more readable --- source3/smbd/open.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'source3/smbd/open.c') diff --git a/source3/smbd/open.c b/source3/smbd/open.c index d142d960f7..eff78d4533 100644 --- a/source3/smbd/open.c +++ b/source3/smbd/open.c @@ -1066,11 +1066,14 @@ static void validate_my_share_entries(struct smbd_server_connection *sconn, bool is_stat_open(uint32 access_mask) { + const uint32_t stat_open_bits = + (SYNCHRONIZE_ACCESS| + FILE_READ_ATTRIBUTES| + FILE_WRITE_ATTRIBUTES); + return (access_mask && - ((access_mask & ~(SYNCHRONIZE_ACCESS| FILE_READ_ATTRIBUTES| - FILE_WRITE_ATTRIBUTES))==0) && - ((access_mask & (SYNCHRONIZE_ACCESS|FILE_READ_ATTRIBUTES| - FILE_WRITE_ATTRIBUTES)) != 0)); + ((access_mask & ~stat_open_bits) == 0) && + ((access_mask & stat_open_bits) != 0)); } /**************************************************************************** -- cgit