From f9bbcb3fb3effdeb9f9f42de77bbde9f2789efdc Mon Sep 17 00:00:00 2001 From: "Christopher R. Hertel" Date: Fri, 7 Nov 1997 03:06:24 +0000 Subject: Modified Files: mangle.c server.c proto.h mangle.c I am planning to replace the mangled_stack array with a proper stack, but found many style inconsistencies (no, really). As you might expect, I have standardized on my own preferences. ;) I also found a potential problem in create_mangled_stack (which I've renamed as reset_mangled_stack). If the stack size were passed into the function as 0 or less, there was the possibility that the array would have been freed twice. I doubt that this ever happens, but I don't like to leave holes. Of course, the fix will be irrelevent once I replace the array with a linked-list-based stack. server.c Changed the call to create_mangled_stack() to a call to reset_mangled_stack(). proto.h Regenerated to match the above changes. (A real comment! How unusual!) (This used to be commit 34d1b3e4fa7a1158f3a3c5c47adf0417c7144095) --- source3/smbd/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source3/smbd/server.c') diff --git a/source3/smbd/server.c b/source3/smbd/server.c index e4e5872035..908cf984b8 100644 --- a/source3/smbd/server.c +++ b/source3/smbd/server.c @@ -3137,7 +3137,7 @@ BOOL reload_services(BOOL test) } } - create_mangled_stack(lp_mangledstack()); + reset_mangled_stack( lp_mangledstack() ); /* this forces service parameters to be flushed */ become_service(-1,True); -- cgit