From 526e875cec15761099438e17df3f56bc2bd5b761 Mon Sep 17 00:00:00 2001
From: Jeremy Allison <jra@samba.org>
Date: Wed, 8 Aug 2012 15:35:28 -0700
Subject: Check error returns from strupper_m() (in all reasonable places).

---
 source3/smbd/service.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

(limited to 'source3/smbd/service.c')

diff --git a/source3/smbd/service.c b/source3/smbd/service.c
index 4fc1aa3e2d..ce9cff90e2 100644
--- a/source3/smbd/service.c
+++ b/source3/smbd/service.c
@@ -257,7 +257,10 @@ static NTSTATUS share_sanity_checks(const struct tsocket_address *remote_address
 		}
 	}
 
-	strupper_m(dev);
+	if (!strupper_m(dev)) {
+		DEBUG(2,("strupper_m %s failed\n", dev));
+		return NT_STATUS_INVALID_PARAMETER;
+	}
 
 	if (lp_print_ok(snum)) {
 		if (!strequal(dev, "LPT1:")) {
-- 
cgit