From 5d92d969dda450cc3564dd2265d2b042d832c542 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Thu, 11 Feb 2010 16:12:29 -0500 Subject: Introduce lp_safe_widelinks() This way we avoid any chance that a configuration reload may turn back on wide links when unix extensions are enabled. --- source3/smbd/service.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'source3/smbd/service.c') diff --git a/source3/smbd/service.c b/source3/smbd/service.c index 1e8c15bfde..4efa63e1dc 100644 --- a/source3/smbd/service.c +++ b/source3/smbd/service.c @@ -858,12 +858,14 @@ connection_struct *make_connection_snum(struct smbd_server_connection *sconn, } /* ROOT Activities: */ + /* explicitly check with lp_widelinks() instead of using + * lp_safe_widelinks() here so that we can correctly warn + * in the logs. */ if (lp_unix_extensions() && lp_widelinks(snum)) { DEBUG(0,("Share '%s' has wide links and unix extensions enabled. " "These parameters are incompatible. " - "Disabling wide links for this share.\n", + "Wide links will be disabled for this share.\n", lp_servicename(snum) )); - lp_do_parameter(snum, "wide links", "False"); } /* @@ -959,7 +961,7 @@ connection_struct *make_connection_snum(struct smbd_server_connection *sconn, * below this directory. We must do this after the VFS init as we * depend on the realpath() pointer in the vfs table. JRA. */ - if (!lp_widelinks(snum)) { + if (!lp_safe_widelinks(snum)) { if (!canonicalize_connect_path(conn)) { DEBUG(0, ("canonicalize_connect_path failed " "for service %s, path %s\n", -- cgit