From 4955ccfff52c18a37cf0ec6e547bb8da0f7269a2 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Tue, 11 May 2010 14:00:38 -0700 Subject: Fix more SMB2-OPLOCK bugs. Only 3 more issues to address then we're good to go on this test. Jeremy. --- source3/smbd/trans2.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'source3/smbd/trans2.c') diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c index 25ca3fd3ae..5d51a7fb90 100644 --- a/source3/smbd/trans2.c +++ b/source3/smbd/trans2.c @@ -5951,7 +5951,15 @@ static NTSTATUS smb2_file_rename_information(connection_struct *conn, return status; } - if (fsp && fsp->base_fsp) { + /* Ok, this looks wrong to me, but appears to + * be how SMB2 renames work. CHECK WITH Microsoft ! + * jra. + */ + if (fsp->oplock_type != NO_OPLOCK) { + return NT_STATUS_SHARING_VIOLATION; + } + + if (fsp->base_fsp) { /* newname must be a stream name. */ if (newname[0] != ':') { return NT_STATUS_NOT_SUPPORTED; -- cgit