From 3036a9c7c12d382b925a1f0e2d6265a3817bd3c4 Mon Sep 17 00:00:00 2001
From: Jeremy Allison <jra@samba.org>
Date: Fri, 17 Jul 2009 21:36:55 -0700
Subject: Fix Coverity CID 929. Potential NULL deref after code refactoring.
 Jeremy.

---
 source3/smbd/trans2.c | 5 +++++
 1 file changed, 5 insertions(+)

(limited to 'source3/smbd')

diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index cb76deb90a..7a0feea291 100644
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -4649,6 +4649,11 @@ NTSTATUS smbd_do_qfilepathinfo(connection_struct *conn,
 			uint32 lock_pid;
 			enum brl_type lock_type;
 
+			/* We need an open file with a real fd for this. */
+			if (!fsp || fsp->is_directory || fsp->fh->fd == -1) {
+				return NT_STATUS_INVALID_LEVEL;
+			}
+
 			if (lock_data_count != POSIX_LOCK_DATA_SIZE) {
 				return NT_STATUS_INVALID_PARAMETER;
 			}
-- 
cgit