From 5b07337cc5e853d0f02554593f4eb842191d67e5 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Tue, 1 Apr 2008 18:18:38 +0200 Subject: smbd: always close the base_fsp even if the real close returned an error Otherwise we may end up with share mode entry without an open file. Volker, Jeremy: please check... metze (This used to be commit 547eacf6058d2bc5b41b266b70f8f4747aca4eae) --- source3/smbd/close.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'source3/smbd') diff --git a/source3/smbd/close.c b/source3/smbd/close.c index 4bd23a35fc..b06c0d1e9c 100644 --- a/source3/smbd/close.c +++ b/source3/smbd/close.c @@ -665,10 +665,6 @@ NTSTATUS close_file(files_struct *fsp, enum file_close_type close_type) status = close_normal_file(fsp, close_type); } - if (!NT_STATUS_IS_OK(status)) { - return status; - } - if ((base_fsp != NULL) && (close_type != SHUTDOWN_CLOSE)) { /* -- cgit