From a47ffac30d3363a93182584859ab273cfc3de2d3 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vlendec@samba.org>
Date: Tue, 13 Jun 2006 19:40:28 +0000
Subject: r16203: Fix potentially writing one result of strtok beyond the end
 of alt_path.

Found by Klocwork, ID 653.

Volker
(This used to be commit 4cb8cf221f986b15de3ac608b173310c14248533)
---
 source3/smbd/msdfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'source3/smbd')

diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c
index 700aa2ae81..55a6850478 100644
--- a/source3/smbd/msdfs.c
+++ b/source3/smbd/msdfs.c
@@ -203,7 +203,8 @@ static BOOL parse_symlink(TALLOC_CTX *ctx, char *buf, struct referral **preflist
 	}
 
 	/* parse out the alternate paths */
-	while(((alt_path[count] = strtok(NULL,",")) != NULL) && count<MAX_REFERRAL_COUNT) {
+	while((count<MAX_REFERRAL_COUNT) &&
+	      ((alt_path[count] = strtok(NULL,",")) != NULL)) {
 		count++;
 	}
 
-- 
cgit