From cb7706cf2c078d09f013b74685aa658af37cf5ba Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sat, 1 Dec 2007 14:38:19 +0100 Subject: TALLOC_FREE early (This used to be commit 4b1f0d1d93d1e7bd0b4fa641d4e9629af8234d71) --- source3/smbd/nttrans.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) (limited to 'source3/smbd') diff --git a/source3/smbd/nttrans.c b/source3/smbd/nttrans.c index 4d5e107ca6..12709f9e02 100644 --- a/source3/smbd/nttrans.c +++ b/source3/smbd/nttrans.c @@ -593,6 +593,7 @@ void reply_ntcreate_and_X(connection_struct *conn, * This filename is relative to a directory fid. */ char *parent_fname = NULL; + char *tmp; files_struct *dir_fsp = file_fsp(root_dir_fid); if(!dir_fsp) { @@ -668,12 +669,14 @@ void reply_ntcreate_and_X(connection_struct *conn, } } - fname = talloc_asprintf(ctx, "%s%s", parent_fname, fname); - if (fname == NULL) { + tmp = talloc_asprintf(ctx, "%s%s", parent_fname, fname); + if (tmp == NULL) { reply_nterror(req, NT_STATUS_NO_MEMORY); END_PROFILE(SMBntcreateX); return; } + TALLOC_FREE(fname); + fname = tmp; } else { /* * Check to see if this is a mac fork of some kind. @@ -1363,6 +1366,7 @@ static void call_nt_transact_create(connection_struct *conn, * This filename is relative to a directory fid. */ char *parent_fname = NULL; + char *tmp; files_struct *dir_fsp = file_fsp(root_dir_fid); if(!dir_fsp) { @@ -1433,12 +1437,14 @@ static void call_nt_transact_create(connection_struct *conn, } } - fname = talloc_asprintf(ctx, "%s%s", parent_fname, fname); - if (fname == NULL) { + tmp = talloc_asprintf(ctx, "%s%s", parent_fname, fname); + if (tmp == NULL) { reply_nterror(req, NT_STATUS_NO_MEMORY); END_PROFILE(SMBntcreateX); return; } + TALLOC_FREE(fname); + fname = tmp; } else { /* * Check to see if this is a mac fork of some kind. -- cgit