From e3f5e474c826940ebaf43256cb06a50309ba3ef5 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 31 Oct 2012 13:13:50 +0100 Subject: smbd: Remove an optimization that became unnecessary After we only collect nonlocal vnns in idx_state.vnns now, at this point we *know* we have something to send to a remote node. The previous code avoided the call to notify_push_remote_blob with an if-statement that has now become unnecessary. Signed-off-by: Volker Lendecke Reviewed-by: Stefan Metzmacher Autobuild-User(master): Stefan Metzmacher Autobuild-Date(master): Tue Mar 26 13:16:39 CET 2013 on sn-devel-104 --- source3/smbd/notify_internal.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'source3/smbd') diff --git a/source3/smbd/notify_internal.c b/source3/smbd/notify_internal.c index ee6f4cc870..2dc86748d9 100644 --- a/source3/smbd/notify_internal.c +++ b/source3/smbd/notify_internal.c @@ -662,7 +662,12 @@ void notify_trigger(struct notify_context *notify, qsort(idx_state.vnns, num_vnns, sizeof(uint32_t), vnn_cmp); last_vnn = 0xffffffff; - remote_blob = NULL; + + if (!notify_push_remote_blob(talloc_tos(), action, filter, path, + &remote_blob, &remote_blob_len)) { + DEBUG(1, ("notify_push_remote_blob failed\n")); + goto done; + } for (i=0; i