From a16b155fc92e7802d17d1ed27b8dc832fa7e531f Mon Sep 17 00:00:00 2001
From: Martin Pool <mbp@samba.org>
Date: Wed, 12 Mar 2003 02:57:48 +0000
Subject: Add example of string overflow which is now caught in developer mode.
(This used to be commit dcf1705782f5d589120624c90b695b81a0332e6b)
---
source3/torture/t_stringoverflow.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
create mode 100644 source3/torture/t_stringoverflow.c
(limited to 'source3/torture/t_stringoverflow.c')
diff --git a/source3/torture/t_stringoverflow.c b/source3/torture/t_stringoverflow.c
new file mode 100644
index 0000000000..b0503adb8f
--- /dev/null
+++ b/source3/torture/t_stringoverflow.c
@@ -0,0 +1,16 @@
+#include "includes.h"
+
+ int main(void)
+{
+ fstring dest;
+
+ printf("running on valgrind? %d\n", RUNNING_ON_VALGRIND);
+
+ /* Try copying a string into an fstring buffer. The string
+ * will actually fit, but this is still wrong because you
+ * can't pstrcpy into an fstring. This should trap in a
+ * developer build. */
+ pstrcpy(dest, "hello");
+
+ return 0;
+}
--
cgit
From 2f07f71d787dc2dfcefac6a1f723c2cde76d4884 Mon Sep 17 00:00:00 2001
From: Martin Pool <mbp@samba.org>
Date: Tue, 18 Mar 2003 05:31:52 +0000
Subject: The new string macros catch a bug at compile that previously only
trapped at runtime, which is great. So we have to try a little harder to
provoke an overflow -- which is still caught nicely in developer mode. (This
used to be commit cea126f62ad411f5efbebc7c5d39297fd8ef9efb)
---
source3/torture/t_stringoverflow.c | 7 +++++++
1 file changed, 7 insertions(+)
(limited to 'source3/torture/t_stringoverflow.c')
diff --git a/source3/torture/t_stringoverflow.c b/source3/torture/t_stringoverflow.c
index b0503adb8f..ec14d81189 100644
--- a/source3/torture/t_stringoverflow.c
+++ b/source3/torture/t_stringoverflow.c
@@ -3,6 +3,7 @@
int main(void)
{
fstring dest;
+ char *ptr = dest;
printf("running on valgrind? %d\n", RUNNING_ON_VALGRIND);
@@ -10,7 +11,13 @@
* will actually fit, but this is still wrong because you
* can't pstrcpy into an fstring. This should trap in a
* developer build. */
+
+#if 0
+ /* As of CVS 20030318, this will be trapped at compile time! */
pstrcpy(dest, "hello");
+#endif /* 0 */
+
+ pstrcpy(ptr, "hello!");
return 0;
}
--
cgit