From 7a3cc345e0508848b0e2bd492789973bcf2d5841 Mon Sep 17 00:00:00 2001 From: Martin Pool Date: Thu, 6 Mar 2003 07:36:08 +0000 Subject: FIXME about crash on failure case. (This used to be commit a387c4209735f8e4c826cad7cb10c5349b2041ec) --- source3/torture/torture.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'source3/torture') diff --git a/source3/torture/torture.c b/source3/torture/torture.c index 2f779b9c89..60d7c2ba74 100644 --- a/source3/torture/torture.c +++ b/source3/torture/torture.c @@ -2922,12 +2922,15 @@ static BOOL run_deletetest(int dummy) printf("finished delete test\n"); fail: - + /* FIXME: This will crash if we aborted before cli2 got + * intialized, because these functions don't handle + * uninitialized connections. */ + cli_close(&cli1, fnum1); cli_close(&cli1, fnum2); cli_setatr(&cli1, fname, 0, 0); cli_unlink(&cli1, fname); - + if (!torture_close_connection(&cli1)) { correct = False; } -- cgit