From de7fd585b11413113304334dd75ba6a207ec69eb Mon Sep 17 00:00:00 2001
From: Jeremy Allison <jra@samba.org>
Date: Tue, 4 Dec 2007 16:56:18 -0800
Subject: The usual !pstring... Jeremy. (This used to be commit
 b676262a781363e7be49b21817668a53cca75c2d)

---
 source3/utils/net_ads.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

(limited to 'source3/utils/net_ads.c')

diff --git a/source3/utils/net_ads.c b/source3/utils/net_ads.c
index d54b817d15..37a02200f5 100644
--- a/source3/utils/net_ads.c
+++ b/source3/utils/net_ads.c
@@ -1636,12 +1636,17 @@ int net_ads_join(int argc, const char **argv)
 	}
 
 	if ( createupn ) {
-		pstring upn;
+		char *upn;
 
 		/* default to using the short UPN name */
-		if ( !machineupn ) {
-			snprintf( upn, sizeof(upn), "host/%s@%s", global_myname(), 
-				ads->config.realm );
+		if (!machineupn ) {
+			upn = talloc_asprintf(ctx,
+					"host/%s@%s", global_myname(),
+					ads->config.realm );
+			if (!upn) {
+				nt_status = NT_STATUS_NO_MEMORY;
+				goto fail;
+			}
 			machineupn = upn;
 		}
 
-- 
cgit