From 8cf78ff55312768d0b454b1d7e0560e04e6296da Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Thu, 30 Apr 2009 15:26:43 -0700 Subject: Get medieval on our ass about SMB1 file descriptors being 16 bits, not an int. Convert all uses of cli_open(), cli_nt_createXXX to NTSTATUS versions. This is smaller than it looks, it just fixes a lot of old code. Next up, ensure all cli_XX functions return NTSTATUS. Jeremy. --- source3/utils/net_rpc.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'source3/utils/net_rpc.c') diff --git a/source3/utils/net_rpc.c b/source3/utils/net_rpc.c index c48eb3dfb5..8689a09e20 100644 --- a/source3/utils/net_rpc.c +++ b/source3/utils/net_rpc.c @@ -4249,7 +4249,7 @@ static void show_userlist(struct rpc_pipe_client *pipe_hnd, int num_tokens, struct user_token *tokens) { - int fnum; + uint16_t fnum; SEC_DESC *share_sd = NULL; SEC_DESC *root_sd = NULL; struct cli_state *cli = rpc_pipe_np_smb_conn(pipe_hnd); @@ -4284,9 +4284,8 @@ static void show_userlist(struct rpc_pipe_client *pipe_hnd, return; } - fnum = cli_nt_create(cli, "\\", READ_CONTROL_ACCESS); - - if (fnum != -1) { + if (!NT_STATUS_IS_OK(cli_ntcreate(cli, "\\", 0, READ_CONTROL_ACCESS, 0, + FILE_SHARE_READ|FILE_SHARE_WRITE, FILE_OPEN, 0x0, 0x0, &fnum))) { root_sd = cli_query_secdesc(cli, fnum, mem_ctx); } -- cgit