From d2c2635a280b1bfbbcd52fa96bbeff3f60672c45 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 23 Nov 2007 12:04:35 +0100 Subject: Make remote_password_change return malloced error strings This fixes a segfault in smbpasswd -r (This used to be commit 49949f0b85007c7c2b3c340c12f3d18909862135) --- source3/web/swat.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'source3/web/swat.c') diff --git a/source3/web/swat.c b/source3/web/swat.c index 95921c0b1d..65f8877bb3 100644 --- a/source3/web/swat.c +++ b/source3/web/swat.c @@ -996,10 +996,11 @@ static bool change_password(const char *remote_machine, const char *user_name, } if (remote_machine != NULL) { - ret = remote_password_change(remote_machine, user_name, old_passwd, - new_passwd, err_str, sizeof(err_str)); - if(*err_str) + ret = remote_password_change(remote_machine, user_name, + old_passwd, new_passwd, &err_str); + if (err_str != NULL) printf("%s\n

", err_str); + SAFE_FREE(err_str); return NT_STATUS_IS_OK(ret); } -- cgit