From c9621a8c005cfc547a26dd92b8183b43665eec5c Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Tue, 17 Aug 2010 08:05:14 +0200 Subject: s3:winbindd: fix error handling in wb_next_grent_fetch_done() We should not use 'result' uninitialized. metze --- source3/winbindd/wb_next_grent.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'source3/winbindd') diff --git a/source3/winbindd/wb_next_grent.c b/source3/winbindd/wb_next_grent.c index 523f8cda8a..1c906bd9dd 100644 --- a/source3/winbindd/wb_next_grent.c +++ b/source3/winbindd/wb_next_grent.c @@ -100,7 +100,15 @@ static void wb_next_grent_fetch_done(struct tevent_req *subreq) status = dcerpc_wbint_QueryGroupList_recv(subreq, state, &result); TALLOC_FREE(subreq); - if (!NT_STATUS_IS_OK(status) || !NT_STATUS_IS_OK(result)) { + if (!NT_STATUS_IS_OK(status)) { + /* Ignore errors here, just log it */ + DEBUG(10, ("query_user_list for domain %s returned %s\n", + state->gstate->domain->name, + nt_errstr(status))); + tevent_req_nterror(req, status); + return; + } + if (!NT_STATUS_IS_OK(result)) { /* Ignore errors here, just log it */ DEBUG(10, ("query_user_list for domain %s returned %s/%s\n", state->gstate->domain->name, -- cgit