From 15d0d9bcfbc1489725082a4e860f9d403a874d4d Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl@samba.org>
Date: Sat, 28 Aug 2010 14:15:31 +0200
Subject: s3: Fix a (highly unlikly) memleak in set_local_machine_name()

---
 source3/lib/substitute.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'source3')

diff --git a/source3/lib/substitute.c b/source3/lib/substitute.c
index e655128f49..d7ca1841ef 100644
--- a/source3/lib/substitute.c
+++ b/source3/lib/substitute.c
@@ -47,16 +47,16 @@ bool set_local_machine_name(const char *local_name, bool perm)
 	char *tmp_local_machine = NULL;
 	size_t len;
 
+	if (already_perm) {
+		return true;
+	}
+
 	tmp_local_machine = SMB_STRDUP(local_name);
 	if (!tmp_local_machine) {
 		return false;
 	}
 	trim_char(tmp_local_machine,' ',' ');
 
-	if (already_perm) {
-		return true;
-	}
-
 	SAFE_FREE(local_machine);
 	len = strlen(tmp_local_machine);
 	local_machine = SMB_CALLOC_ARRAY(char, len+1);
-- 
cgit