From 288fb9d612da7d2b5abe3c7544d25775b0c4d42a Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sat, 26 Mar 2011 13:33:40 +0100 Subject: s3: Fix an uninitialized variable read The "is_valid_policy_handle" in the exit path reads uninitialized data Lets see if this fixes Coverity ID 2172 which complains about h being dereferenced in the dcerpc_winreg_CloseKey. Autobuild-User: Volker Lendecke Autobuild-Date: Sat Mar 26 14:24:28 CET 2011 on sn-devel-104 --- source3/services/svc_winreg_glue.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'source3') diff --git a/source3/services/svc_winreg_glue.c b/source3/services/svc_winreg_glue.c index dc367c2c41..06f3f9195f 100644 --- a/source3/services/svc_winreg_glue.c +++ b/source3/services/svc_winreg_glue.c @@ -153,7 +153,8 @@ bool svcctl_set_secdesc(struct messaging_context *msg_ctx, { struct dcerpc_binding_handle *h = NULL; uint32_t access_mask = SEC_FLAG_MAXIMUM_ALLOWED; - struct policy_handle hive_hnd, key_hnd; + struct policy_handle hive_hnd; + struct policy_handle key_hnd = { 0, }; char *key = NULL; bool ok = false; TALLOC_CTX *tmp_ctx; -- cgit