From 29a51a22df68ae8929bd8312df03c72bbfa26f81 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 1 Jun 2012 15:15:07 +0200 Subject: s3: Avoid a lot of calls to serverid_exists() Signed-off-by: Stefan Metzmacher Autobuild-User: Stefan Metzmacher Autobuild-Date: Fri Jun 1 18:58:30 CEST 2012 on sn-devel-104 --- source3/locking/locking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source3') diff --git a/source3/locking/locking.c b/source3/locking/locking.c index 00a46fa619..76c2bc7a48 100644 --- a/source3/locking/locking.c +++ b/source3/locking/locking.c @@ -620,7 +620,7 @@ bool is_valid_share_mode_entry(const struct share_mode_entry *e) num_props += (EXCLUSIVE_OPLOCK_TYPE(e->op_type) ? 1 : 0); num_props += (LEVEL_II_OPLOCK_TYPE(e->op_type) ? 1 : 0); - if (serverid_exists(&e->pid) && (num_props > 1)) { + if ((num_props > 1) && serverid_exists(&e->pid)) { smb_panic("Invalid share mode entry"); } return (num_props != 0); -- cgit