From 29b5a95b1f85f1e7493fb6be4ea5eaf7931d9c23 Mon Sep 17 00:00:00 2001
From: Amitay Isaacs <amitay@gmail.com>
Date: Fri, 11 Nov 2011 15:29:35 +1100
Subject: py_passdb: Cannot steal an item pointer from an array

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Fri Nov 11 12:04:33 CET 2011 on sn-devel-104
---
 source3/passdb/py_passdb.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

(limited to 'source3')

diff --git a/source3/passdb/py_passdb.c b/source3/passdb/py_passdb.c
index 0f71837900..de278399b1 100644
--- a/source3/passdb/py_passdb.c
+++ b/source3/passdb/py_passdb.c
@@ -2236,7 +2236,7 @@ static PyObject *py_pdb_enum_aliasmem(pytalloc_Object *self, PyObject *args)
 	struct pdb_methods *methods;
 	TALLOC_CTX *tframe;
 	PyObject *py_alias_sid;
-	struct dom_sid *alias_sid, *member_sid;
+	struct dom_sid *alias_sid, *member_sid, *tmp_sid;
 	PyObject *py_member_list, *py_member_sid;
 	size_t num_members;
 	int i;
@@ -2271,10 +2271,15 @@ static PyObject *py_pdb_enum_aliasmem(pytalloc_Object *self, PyObject *args)
 	}
 
 	for(i=0; i<num_members; i++) {
-		py_member_sid = pytalloc_steal(dom_sid_Type, &member_sid[i]);
-		if (py_member_sid) {
-			PyList_Append(py_member_list, py_member_sid);
+		py_member_sid = pytalloc_new(struct dom_sid, dom_sid_Type);
+		if (py_member_sid == NULL) {
+			PyErr_NoMemory();
+			talloc_free(tframe);
+			return NULL;
 		}
+		tmp_sid = pytalloc_get_ptr(py_member_sid);
+		*tmp_sid = member_sid[i];
+		PyList_Append(py_member_list, py_member_sid);
 	}
 
 	talloc_free(tframe);
-- 
cgit