From 37870e28ab4ef0ebcec0ed18714a6fef9a5a16d4 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 16 Mar 2011 21:48:50 +0100 Subject: s3: Fix Coverity ID 2233, REVERSE_INULL We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425 --- source3/rpc_server/netlogon/srv_netlog_nt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source3') diff --git a/source3/rpc_server/netlogon/srv_netlog_nt.c b/source3/rpc_server/netlogon/srv_netlog_nt.c index bfa3bb25e8..e5d61242e3 100644 --- a/source3/rpc_server/netlogon/srv_netlog_nt.c +++ b/source3/rpc_server/netlogon/srv_netlog_nt.c @@ -490,7 +490,7 @@ NTSTATUS _netr_NetrEnumerateTrustedDomains(struct pipes_struct *p, status = NT_STATUS_OK; out: - if (h && is_valid_policy_hnd(&pol)) { + if (is_valid_policy_hnd(&pol)) { dcerpc_lsa_Close(h, p->mem_ctx, &pol, &result); } -- cgit