From 69a67a1b7358d45f7a75fe8f87f652fc237342f7 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 3 Jan 2012 22:19:27 +0100 Subject: s3: Check for the packet size before accessing it Autobuild-User: Jeremy Allison Autobuild-Date: Wed Jan 4 15:16:20 CET 2012 on sn-devel-104 --- source3/smbd/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'source3') diff --git a/source3/smbd/process.c b/source3/smbd/process.c index c448267781..f366600ab8 100644 --- a/source3/smbd/process.c +++ b/source3/smbd/process.c @@ -1409,8 +1409,7 @@ static connection_struct *switch_message(uint8 type, struct smb_request *req, in /* Make sure this is an SMB packet. smb_size contains NetBIOS header * so subtract 4 from it. */ - if (!valid_smb_header(sconn, req->inbuf) - || (size < (smb_size - 4))) { + if ((size < (smb_size - 4)) || !valid_smb_header(sconn, req->inbuf)) { DEBUG(2,("Non-SMB packet of length %d. Terminating server\n", smb_len(req->inbuf))); exit_server_cleanly("Non-SMB packet"); -- cgit