From 7cf04431594e09043b3b53144fc8511d20b088ee Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl@samba.org>
Date: Fri, 25 Jun 2010 11:47:30 +0200
Subject: s3: Fix a winbind crash

nss_get_info_cached might deep inside sequence_number() invalidate the
ads_struct without telling its callers.
---
 source3/winbindd/winbindd_ads.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

(limited to 'source3')

diff --git a/source3/winbindd/winbindd_ads.c b/source3/winbindd/winbindd_ads.c
index 92e1188714..00b53a205c 100644
--- a/source3/winbindd/winbindd_ads.c
+++ b/source3/winbindd/winbindd_ads.c
@@ -563,6 +563,16 @@ static NTSTATUS query_user(struct winbindd_domain *domain,
 		info->full_name = ads_pull_string(ads, mem_ctx, msg, "name");
 	}
 
+	/*
+	 * We have to re-fetch ads from the domain,
+	 * nss_get_info_cached might have invalidated it.
+	 */
+	ads = ads_cached_connection(domain);
+	if (ads == NULL) {
+		domain->last_status = NT_STATUS_SERVER_DISABLED;
+		goto done;
+	}
+
 	if (!ads_pull_uint32(ads, msg, "primaryGroupID", &group_rid)) {
 		DEBUG(1,("No primary group for %s !?\n",
 			 sid_string_dbg(sid)));
-- 
cgit